Skip to content

chore(runcommand): switch to new sdk structure#1484

Merged
rubenhoenle merged 1 commit into
mainfrom
feat/sdk-migration-runcommand
Jul 22, 2026
Merged

chore(runcommand): switch to new sdk structure#1484
rubenhoenle merged 1 commit into
mainfrom
feat/sdk-migration-runcommand

Conversation

@rubenhoenle

@rubenhoenle rubenhoenle commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

relates to STACKITCLI-354

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
rubenhoenle requested a review from a team as a code owner July 21, 2026 08:59
@rubenhoenle
rubenhoenle force-pushed the feat/sdk-migration-runcommand branch from 93c956c to 175e3c7 Compare July 21, 2026 09:53
SerseusWasTaken
SerseusWasTaken approved these changes Jul 22, 2026
View reviewed changes

@SerseusWasTaken SerseusWasTaken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rubenhoenle
rubenhoenle enabled auto-merge (squash) July 22, 2026 08:41
@rubenhoenle
rubenhoenle force-pushed the feat/sdk-migration-runcommand branch from 175e3c7 to 07df51f Compare July 22, 2026 08:41
@rubenhoenle
rubenhoenle merged commit fa62984 into main Jul 22, 2026
3 checks passed
@rubenhoenle
rubenhoenle deleted the feat/sdk-migration-runcommand branch July 22, 2026 08:46
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/create 46.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/describe 75.47% (+0.96%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/list 41.51% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/describe 65.22% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/list 62.22% (-0.82%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/services/runcommand/client 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/create/create.go 46.94% (ø) 49 23 26
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/describe/describe.go 75.47% (+0.96%) 53 (+2) 40 (+2) 13 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/list/list.go 41.51% (ø) 53 22 31
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/describe/describe.go 65.22% (ø) 46 30 16
github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/list/list.go 62.22% (-0.82%) 45 (-1) 28 (-1) 17 👎
github.com/stackitcloud/stackit-cli/internal/pkg/services/runcommand/client/client.go 0.00% (ø) 1 0 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/server/command/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/command/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/command/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/command/template/list/list_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SerseusWasTaken SerseusWasTaken SerseusWasTaken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rubenhoenle @SerseusWasTaken